Bad links from proposed tag combination page.

The proposed tag combination page sends you to https://www.librarything.com/tag/hunting+birds

The correct link would be https://www.librarything.com/tag/hunting%20birds

This is happening consistently. Since the + link shows no books and no combination votes, this makes accurate voting difficult.

The tag details page with the vote also sends you to the wrong page.

Confirming - and it happens on other ways to access tags too

Verified.

For further context to whomever is assigned this bug, I believe it backdates ~2 months (See note #8 in this thread https://www.librarything.com/topic/349290#8094695 The primary bug about the recursive loop I reported got solved, but spaces vs plus marks in tags have had issues)

I marked this as verified last week and let ccatalfo know, but didn't actually post. We'll need to do another round of URL stuff soon, I'm sure, this will be on the plate. Thanks for your patience in the meantime.

bump

See also https://www.librarything.com/topic/354568

What's the status of fixing this bug?

I don't see us being able to get to another round of URL stuff/bugs until at least after the holidays, sorry for the wait! Please check back in in January, if you wish to do so?

It's really such a pain that the URLs LT creates don't go where they are meant to. It's beem six months now.

Anything happening with this?

https://www.librarything.com/topic/357023

I've completely stopped proposing tag combinations or voting on them because of this bug since anything with spaces is bugged. It really should be a priority one to fix since it affects the majority of tags in all ways, including opening the tag page

I think it's a variation on https://www.librarything.com/topic/349343 which was in March.

This is on the list, we're hoping to get another round of bug cleaning done in the near future, no exact timeline yet. (Hopefully sooner than later!)

bump

Bump. It's already later.

Bump.

This is really frustrating. It's so hard to check tags from the Proposed Tag Combinations page or go to the proposal from the tag page.

I apologize that this took so long to fix. I hope it works now, but there are a lot of types of tags, so let me know if I broke something else on the page : )

https://www.librarything.com/tags_combinations.php

>18 knerd.knitter: Oh,wow! Thank you! Thank you so much!

>18 knerd.knitter:

Going from the tag combination page does get me to the tag page, so thank you for that!

However, the tag page itself does not show the proposal: https://www.librarything.com/tag/detail/juvenile%2Bfiction%2B%2F%2Bsocial%2Bissu...

Whoops, the link at the top of the tag page " There are open..." still has the plus signs.

Also, the link from a tag page to one's own catalog still has the plus signs in it.

Example: if I'm on the tag page for "science fiction" ( https://www.librarything.com/tag/science%20fiction ) at the top of the page it says "You use: science fiction (331)" and clicking on the link there takes me to https://www.librarything.com/catalog/norabelle414&tag=science+fiction when it should take me to https://www.librarything.com/catalog/norabelle414?tag=science%20fiction

Okay, so now from here https://www.librarything.com/tag/fairies%20--%20juvenile%20fiction the link to the tag combinations is correct.

>22 norabelle414: I'll get that fixed in a minute.

Fixed.

>25 knerd.knitter:

Thank you SO much! All looks good now.

>25 knerd.knitter: Thank you!!!

I found a couple more:

1) On the Tag Details page, clicking the link at the top to get back to the tag page has a plus sign in the URL.

2) The links to individual aliases on the alias tab have plus signs in them

Example: https://www.librarything.com/tag/detail/green%20tea#tab:aliases
Clicking on the first alias goes to https://www.librarything.com/tag/green+tea&norefer=1

Additionally, the &norefer=1 doesn't seem to be working. It takes you to the tag page as if "&norefer=1" were part of the tag.

>28 norabelle414: Fixed.

Not entirely fixed.

If I am on the page showing a proposed combination such as https://www.librarything.com/tag/detail/Criminals%20-%20Juvenile%20fiction#tab:c... and click on one of the tags, I get "none" https://www.librarything.com/tag/criminals%2B-%2Bjuvenile%2Bfiction even when there are, in fact, books on the tag page: https://www.librarything.com/tag/Criminals%20-%20Juvenile%20fiction

I got a bad one yesterday, but the same one worked later. The thing to note is a plus where there should be a space.

>30 lilithcat: Thank you for finding those; I will get the encoding fixed.

>30 lilithcat: Fixed.

>33 knerd.knitter:
Thank you!

Marking back as fixed: thanks knerd.knitter!